github: Add a workaround for nextest failing on Windows#16342
Merged
Dinnerbone merged 1 commit intoruffle-rs:masterfrom May 16, 2024
Merged
github: Add a workaround for nextest failing on Windows#16342Dinnerbone merged 1 commit intoruffle-rs:masterfrom
Dinnerbone merged 1 commit intoruffle-rs:masterfrom
Conversation
torokati44
added
the
github_actions
Contributor
|
Just for ease of reference: |
EliahKagan
added a commit
to EliahKagan/gitoxide
that referenced
this pull request
May 17, 2024
This sets the `RUSTUP_WINDOWS_PATH_ADD_BIN` environment variable in the multi-platform test job, to work around nextest-rs/nextest#1493 which is keeping the test runner from working on Windows. See also ruffle-rs/ruffle#16342, which gave the idea for this, and various other projects that have made such changes, linked inhttps://github.com/nextest-rs/nextest/issues/1493.
EliahKagan
added a commit
to EliahKagan/gitoxide
that referenced
this pull request
May 17, 2024
This sets the `RUSTUP_WINDOWS_PATH_ADD_BIN` environment variable in the multi-platform test job, to work around nextest-rs/nextest#1493 which is keeping the test runner from working on Windows. See also ruffle-rs/ruffle#16342, which gave the idea for this, and various other projects that have made such changes, linked in nextest-rs/nextest#1493.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will hopefully prevent CI failures like these:
https://github.com/ruffle-rs/ruffle/actions/runs/9103363884/job/25025064793
https://github.com/ruffle-rs/ruffle/actions/runs/9103952906/job/25026859930
Thanks for finding the issues linked from the code, @Dinnerbone!